File upload extension gets doubled if filename already exists

PHPMaker General Discussion (PHPMaker)
1

If I upload a file named document.pdf and a file with the same name already exists in the uploads folder, the upload is renamed to document(1).pdf.pdf.
The culprit seems to be the function UniqueFilename in phpfn.php. Version 2025.7.

2

Inside that UniqueFilename function, just change this code:

$fn = $filename . "(" . $i . ")" . ($ext ? "." . $ext : "");

to:

$fn = $filename . "(" . $i . ")"; // . ($ext ? "." . $ext : "");
3

That works, thanks!
Btw, the parenthesis count is starting with 2, not 1. Had to change:

$i = 1;

to

$i = 0;

4

I think the counter should be started from 2. Although there is no suffix 1 for those same files, the counter started from 2 means that, it is the second file with the same file name. And if you upload the same file name again, then it will use 3, and so forth.

From that suffix we are able to know, how many files with that same file name. Just my two cents.