Page Redirecting

PHPMaker General Discussion (PHPMaker)
1

In version v2026.11.0 (2026/06/03) I noticed an issue with redirection behavior.

The fix mentioned:

  • Edit Page return page fixed

works for Edit pages, but it seems other cases are still affected.

Issue:

In the List Page, the following redirect does NOT work:

// Page Redirecting event
public function pageRedirecting(?string &$url): void
{
    $url = "Platform"; // or $url = HtmlEncode(GetUrl("Platform"));
}

The page simply does not navigate to the specified URL.

Expected behavior:

The List page should redirect to "Platform" when pageRedirecting() is triggered.

Actual behavior:

No redirect happens on List pages, while Edit Page return navigation is fixed correctly in this version.

Question:

Is this fix intended only for Edit pages, or should it also cover List pages and other page types?

2

Platform does not sound like a normal page, is it a Custom File or an external page? If it is Custom File, make sure the URL is correct. You can check valid routes and URLs by php bin/console router:debug, see Console Commands.

If you have added the route recently or using "production" mode, make sure you have cleared cache, read: Clearing Symfony Cache.

3

While reviewing the code, I noticed something that may need clarification.

In page classes, terminate() can set:

$this->Response = new RedirectResponse(GetUrl($url), Config("REDIRECT_STATUS_CODE"));

However, in BaseController::runPage(), $page->Response is only checked before page rendering:

if (($response = $page->Response) instanceof Response) {
    ...
    $page->terminate();
}

Later, terminate() is called again, but I cannot find any code that re-reads $page->Response after terminate() has executed.

From my reading, if terminate() creates a new RedirectResponse, that response does not appear to be assigned back to the controller's $response variable and therefore may never be returned.

Am I missing another location where $page->Response is consumed after terminate() runs, or is the Response created inside terminate() no longer used in the Symfony-based architecture?

4

I noticed another potential issue related to IsModal.

In terminate() there is logic like:

if ($this->IsModal) {
    ...
}

However, IsModal is typically assigned during run():

public function run(): void
{
    // Is modal
    $this->IsModal = IsModal();
}

I have encountered cases where terminate() is executed before run() (or before other methods that initialize $this->IsModal). In those situations, $this->IsModal may not contain the expected value, which can lead to incorrect behavior.

As a workaround, I have sometimes used:

public function pageUnload(): void
{
    $this->IsModal = IsModal();
}

to ensure the property is initialized before terminate() uses it.

Would it be safer for terminate() to call IsModal() directly instead of relying on $this->IsModal, for example:

if (IsModal()) {
    ...
}

or is there another part of the framework lifecycle that guarantees $this->IsModal has already been initialized before terminate() is called?